DM-7665: fixed the region parsing issue regarding region used separators contained in some property values #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 22, 2016 18:19
…ors in the values of some properties which have string type values. delete a space line handle ';' and ' ' in region description and region property at server side. fixed some computational bug for parsing text and font string in region property.
robyww
approved these changes
Sep 23, 2016
|
|
||
| // collect region lines and each line may contain coordinate, region description or both | ||
| var regionLines = regionData.reduce( (rLines, oneLine) => { | ||
|
|
There was a problem hiding this comment.
This is a lot of code for a reduce function. I think you should break it up so that it is a little easier to follow. I see that the old approach was a reduce as well but it was not as big.
There was a problem hiding this comment.
Thanks for the comment.
…e in RegionFactory.js.
|
Breaking up the code as the comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the parsing errors which happen when
Test sample,
upload firefly_test_data/region-test-files/regionText.reg
or
visit localhost:8080/demo/ffapi-highlevel-test.html by clicking 'test-open' and 'create_region_layer'